Updated circleci config to push to gar#573
Open
bwells-moz wants to merge 13 commits intofirefox-devtools:masterfrom
Open
Updated circleci config to push to gar#573bwells-moz wants to merge 13 commits intofirefox-devtools:masterfrom
bwells-moz wants to merge 13 commits intofirefox-devtools:masterfrom
Conversation
julienw
reviewed
Jun 3, 2025
julienw
reviewed
Jun 3, 2025
This reverts commit 48ebec2.
julienw
reviewed
Jun 5, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
If using the gcp-gcr orb, we should use gcr-auth and push-image from that orb directly.
The gcp-cli is probably not needed!
Comment on lines
+216
to
+222
| echo 'export GOOGLE_PROJECT_ID="moz-fx-profiler-prod"' >> "$BASH_ENV" | ||
| echo "export OIDC_WIP_ID=$GCPV2_WORKLOAD_IDENTITY_POOL_ID" >> "$BASH_ENV" | ||
| echo "export OIDC_WIP_PROVIDER_ID=$GCPV2_CIRCLECI_WORKLOAD_IDENTITY_PROVIDER" >> "$BASH_ENV" | ||
| echo "export GOOGLE_PROJECT_NUMBER=$GCPV2_WORKLOAD_IDENTITY_POOL_PROJECT_NUMBER" >> "$BASH_ENV" | ||
| echo "export OIDC_SERVICE_ACCOUNT_EMAIL=$GCP_SERVICE_ACCOUNT_EMAIL" >> "$BASH_ENV" | ||
| echo 'export GCP_GAR_REPO="profiler-prod"' >> "$BASH_ENV" | ||
| echo "export GAR_IMAGE=\"<<parameters.registry-url>>/${GOOGLE_PROJECT_ID}/${GCP_GAR_REPO}/<<parameters.image>>\"" >> $BASH_ENV |
Contributor
There was a problem hiding this comment.
For more simplicity, and if they are needed, I would create these env variables directly in the step below, like we do for IMAGE_VERSION_TAG IMAGE_LATEST_TAG.
For the hardcoded ones, it could be easier to add an environment property to the job or step like described in parts 2 and 3 in https://circleci.com/docs/set-environment-variable/.
Using the commands with $BASH_ENV are useful if:
- we want some interpolation
- we want these variables present for all the following steps
But I'm not opposed keeping them here if you prefer, buy only if we need them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.