Skip to content

fix: form fields are passed as list instead of dict#464

Open
Shreyaav18 wants to merge 1 commit intofireform-core:mainfrom
Shreyaav18:refactor/fields-as-dict
Open

fix: form fields are passed as list instead of dict#464
Shreyaav18 wants to merge 1 commit intofireform-core:mainfrom
Shreyaav18:refactor/fields-as-dict

Conversation

@Shreyaav18
Copy link
Copy Markdown

@Shreyaav18 Shreyaav18 commented Apr 19, 2026

Fields were being passed as a list.
in main.py

reader = PdfReader(prepared_pdf)
    fields = reader.get_fields()

returns a dict.
Updated controller.py, file_manipulator.py to consistently use a dict. No logic changes were made.
All tests pass.
fixes issue #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant