adapt for MeshSequence #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
approved these changes
Sep 9, 2025
Contributor
tommbendall
left a comment
tommbendall
left a comment
There was a problem hiding this comment.
Thanks for this -- this looks good to me. I'd plan on eventually removing the except part of the latlon mesh creation
tommbendall
added
the
upstream
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
2308561 to
70b99ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for firedrakeproject/firedrake#3478, but can go independently.