Disable -O3 for GCC 15#5105
Closed
connorjward wants to merge 2 commits into
Closed
Conversation
We found out that -O3 was leading to garbage values in tricky interpolation kernels with GCC 15 on both Ubuntu 26.04 and Arch. This will allow us to support Ubuntu 26.04.
JHopeCollins
approved these changes
May 13, 2026
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
LGTM, thanks for tracking this down!
Contributor
Author
|
I'm going to fold this into #5085 because this only really makes sense in the context of that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found out that -O3 was leading to garbage values in tricky interpolation kernels with GCC 15 on both Ubuntu 26.04 and Arch.
This will allow us to support Ubuntu 26.04.
I have also refactored
Compiler.cflagsand friends because the bugfix flags have to come after the optflags.Also removed a bunch of very very old bugfix cflags - GCC 7 was last updated in 2019 and I'd be surprised if the rest of our software stack works with such an old compiler.