firedrake-configure options for Ubuntu 2026.04

.github/workflows/core.yml

@@ -73,17 +73,16 @@ jobs:
         arch: [default, complex]
     runs-on: [self-hosted, Linux]
     container:
-      # TODO: set to 'ubuntu:latest'
-      image: ubuntu:noble
+      image: ubuntu:latest
     env:
       OMPI_ALLOW_RUN_AS_ROOT: 1
       OMPI_ALLOW_RUN_AS_ROOT_CONFIRM: 1
       OMP_NUM_THREADS: 1
       OPENBLAS_NUM_THREADS: 1
       FIREDRAKE_CI: 1
       PYOP2_SPMD_STRICT: 1
-      # Disable fast math as it exposes compiler bugs
-      PYOP2_CFLAGS: -fno-fast-math
+      # Disable some compiler optimisations as they cause runner-specific bugs
+      PYOP2_CFLAGS: -O1 -fno-fast-math
       # NOTE: One should occasionally update test_durations.json by running
       # 'make test_durations' inside a 'firedrake:latest' Docker image.
       EXTRA_PYTEST_ARGS: --splitting-algorithm least_duration --timeout=600 --timeout-method=thread -o faulthandler_timeout=660 --durations-path=./firedrake-repo/tests/test_durations.json --durations=50
@@ -300,7 +299,7 @@ jobs:
     name: Build and test Firedrake (Linux CUDA)
     runs-on: [self-hosted, Linux, gpu]
     container:
-      # TODO: set to 'ubuntu:latest'
+        # TODO: set to 'ubuntu:latest'
       image: ubuntu:noble
       options: --gpus all
     if: inputs.test_gpu

docs/notebooks/11-extract-adjoint-solutions.ipynb

@@ -54826,6 +54826,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
+    "# NBVAL_SKIP\n",
     "tape.visualise(\"tape.pdf\")"
    ]
   },
@@ -54849,6 +54850,7 @@
     }
    ],
    "source": [
+    "# NBVAL_SKIP\n",
     "from pdf2image import convert_from_path\n",
     "\n",
     "images = convert_from_path(\"tape.pdf\")\n",

firedrake/checkpointing.py

@@ -1547,7 +1547,7 @@ def _load_function_topology(self, tmesh, element, tf_name, idx=None):
                 if timestepping:
                     assert idx is not None, "In timestepping mode: idx parameter must be set"
                 else:
-                    assert idx is None, "In non-timestepping mode: idx parameter msut not be set"
+                    assert idx is None, "In non-timestepping mode: idx parameter must not be set"
             else:
                 raise RuntimeError(f"Function {path} not found in {self.filename}")
             with tf.dat.vec_wo as vec:

pyop2/compilation.py

@@ -278,33 +278,35 @@ def ld(self):
         return self._ld
 
     @property
-    def cflags(self):
-        cflags = self._cflags + self._extra_compiler_flags + self.bugfix_cflags
-        if self._debug:
-            cflags += self._debugflags
-        else:
-            cflags += self._optflags
-        cflags += tuple(shlex.split(configuration["cflags"]))
-        return cflags
+    def cflags(self) -> tuple[str, ...]:
+        return (
+            *self._cflags,
+            *(self._debugflags if self._debug else self._optflags),
+            *self.bugfix_cflags,
+            *self._extra_compiler_flags,
+            *shlex.split(configuration["cflags"]),
+        )
 
     @property
-    def cxxflags(self):
-        cxxflags = self._cxxflags + self._extra_compiler_flags + self.bugfix_cflags
-        if self._debug:
-            cxxflags += self._debugflags
-        else:
-            cxxflags += self._optflags
-        cxxflags += tuple(shlex.split(configuration["cxxflags"]))
-        return cxxflags
+    def cxxflags(self) -> tuple[str, ...]:
+        return (
+            *self._cxxflags,
+            *(self._debugflags if self._debug else self._optflags),
+            *self.bugfix_cflags,
+            *self._extra_compiler_flags,
+            *shlex.split(configuration["cxxflags"]),
+        )
 
     @property
-    def ldflags(self):
-        ldflags = self._ldflags + self._extra_linker_flags
-        ldflags += tuple(shlex.split(configuration["ldflags"]))
-        return ldflags
+    def ldflags(self) -> tuple[str, ...]:
+        return (
+            *self._ldflags,
+            *self._extra_linker_flags,
+            *shlex.split(configuration["ldflags"]),
+        )
 
     @property
-    def bugfix_cflags(self):
+    def bugfix_cflags(self) -> tuple[str, ...]:
         return ()
 
 
@@ -348,30 +350,17 @@ class LinuxGnuCompiler(Compiler):
     _debugflags = ("-O0", "-g")
 
     @property
-    def bugfix_cflags(self):
+    def bugfix_cflags(self) -> tuple[str, ...]:
         """Flags to work around bugs in compilers."""
-        ver = self._version
-        cflags = ()
-        if Version("4.8.0") <= ver < Version("4.9.0"):
-            # GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61068
-            cflags = ("-fno-ivopts",)
-        if Version("5.0") <= ver <= Version("5.4.0"):
-            cflags = ("-fno-tree-loop-vectorize",)
-        if Version("6.0.0") <= ver < Version("6.5.0"):
-            # GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79920
-            cflags = ("-fno-tree-loop-vectorize",)
-        if Version("7.1.0") <= ver < Version("7.1.2"):
-            # GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81633
-            cflags = ("-fno-tree-loop-vectorize",)
-        if Version("7.3") <= ver <= Version("7.5"):
-            # GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90055
-            # See also https://github.com/firedrakeproject/firedrake/issues/1442
-            # And https://github.com/firedrakeproject/firedrake/issues/1717
-            # Bug also on skylake with the vectoriser in this
-            # combination (disappears without
-            # -fno-tree-loop-vectorize!)
-            cflags = ("-fno-tree-loop-vectorize", "-mno-avx512f")
-        return cflags
+        cflags = []
+        if not self._debug and self._version >= Version("15"):
+            # Disable '-O3' for GCC versions >=15 because it causes issues with
+            # complex interpolation kernels
+            # TODO: revisit this in later GCC releases to see if we can set a
+            # maximum version constraint
+            # (see https://github.com/firedrakeproject/firedrake/issues/5107)
+            cflags.append("-O2")
+        return tuple(cflags)
 
 
 class LinuxClangCompiler(Compiler):

pyproject.toml

@@ -111,7 +111,8 @@ ci = [
   "networkx",
   "ngsPETSc>=0.2.0",
   "pdf2image",
-  "pygraphviz",
+  # TODO: restore this (see https://github.com/firedrakeproject/firedrake/issues/5106)
+  # "pygraphviz",
   "pylit",
   "pytest",
   "pytest-order",
@@ -129,7 +130,8 @@ docker = [  # Used in firedrake-vanilla container
   "nbval",
   "networkx",
   "pdf2image",
-  "pygraphviz",
+  # TODO: restore this (see https://github.com/firedrakeproject/firedrake/issues/5106)
+  # "pygraphviz",
   "pylit",
   "pytest",
   "pytest-order",