Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to run a preconditioner based on Slate globally matrix-free but with jacobi preconditioner. In that case we ask to assemble the diagonal of an expression. Ideally this would have been part of the PR #2259 which we merged a month ago, since it's when I dropped the error message that "Diagonal + slate not supported" and introduced
DiagonalTensorsin Slate. The existing diagonal infrastructure only had to be adapted to give the diagonal tensor back as a vector. Before this PR we were not able to run a solve in a Slate based preconditioner with Jacobi and'mat_type': 'matfree'in its parameters