Tidy up interpolation tsfc<->firedrake interface #1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenHill
force-pushed
the
ReubenHill/tsfc-interp-tidy
branch
from
b4675e7 to
8b006c1
Compare
See issue firedrakeproject/tsfc#232 Note for some reason this breaks tests/regression/test_interpolate.py::test_piola which exits without stacktrace.
ReubenHill
force-pushed
the
ReubenHill/tsfc-interp-tidy
branch
from
8b006c1 to
40f235c
Compare
dham
previously approved these changes
Nov 24, 2020
Use new interface that informs if a manufactured coordinates coefficient is the first coefficient
ReubenHill
force-pushed
the
ReubenHill/tsfc-interp-tidy
branch
from
40f235c to
9a5adc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue firedrakeproject/tsfc#232. firedrakeproject/tsfc#233 must be merged first. Please feel free to bikeshed this whilst it's WIP.