Handle Real elements analogously to DG for tensor product cells#237
Merged
connorjward merged 3 commits intomainfrom Mar 24, 2026
Merged
Handle Real elements analogously to DG for tensor product cells#237connorjward merged 3 commits intomainfrom
connorjward merged 3 commits intomainfrom
Conversation
connorjward
added a commit
to firedrakeproject/firedrake
that referenced
this pull request
Mar 18, 2026
pbrubeck
reviewed
Mar 24, 2026
pbrubeck
reviewed
Mar 24, 2026
connorjward
force-pushed
the
connorjward/handle-real
branch
from
87bd7fb to
63baca8
Compare
pbrubeck
approved these changes
Mar 24, 2026
connorjward
added a commit
to firedrakeproject/firedrake
that referenced
this pull request
Mar 24, 2026
* Fixes for Real x extruded following firedrakeproject/fiat#237 * Don't special case Real so much
connorjward
added a commit
to firedrakeproject/firedrake
that referenced
this pull request
Apr 1, 2026
Due to firedrakeproject/fiat#237 the embedding element used to save a function no longer necessarily matches the one we would now pick (because a CG element on an extruded mesh now reports its family as CG instead of 'TensorProductElement'). Removing this assertion is sufficient to fix the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke Firedrake last time this got merged so leaving as draft for now...