Conversation
|
I think this still needs the tweak to |
3434ebe to
2497ade
Compare
37c19ce to
1c0dd09
Compare
1c0dd09 to
c9704c3
Compare
dham
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some under-used methods for ufl elements broke after the
gdim / value_shapeufl API changes.Here we fix (and test) these methods, with an optional
domainkwarg.This includes
ufl_element.value_shape(domain). Note thatvalue_shapeused to be an attribute, and now passingdomain=Noneshould work fine for non-Piola mapped elements.Fixes #105