flamenco: remove duplicated check #7664
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the same condition removed from fd_borrowed_account_is_writable is checked in fd_instr_acc_is_writable_idx
two-heart
force-pushed
the
rm-dup-writeable-check
branch
from
2f8e78e to
5c81587
Compare
Contributor
intrigus-lgtm
left a comment
intrigus-lgtm
left a comment
There was a problem hiding this comment.
The implementation doesn't closely follow the updated permalink.
Agave has refactored the code such that a borrowed account now directly references an instruction account: https://github.com/anza-xyz/agave/blob/6dcc39fcba90fbb5c924c71a1ef287c234f56c17/transaction-context/src/lib.rs#L725, meaning that a call to fd_instr_acc_is_writable_idx is unnecessary now and instead a simple access to self.instruction_account.is_signer() suffices.
IMHO, we should either fully follow the changes agave did or none, but not a mix.
If we want to go through with the PR as-is, then we should also remove the duplicated check from fd_borrowed_account_is_signer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the same condition removed from fd_borrowed_account_is_writable is checked in fd_instr_acc_is_writable_idx