banks: adding seed, fixing new/join pattern, removing templatization for complex types#7649
Merged
ibhatt-jumptrading merged 45 commits intofiredancer-io:mainfrom Jan 7, 2026
Conversation
ibhatt-jumptrading
force-pushed
the
ibhatt/unwind_banks_cow
branch
from
91a792c to
849f619
Compare
ibhatt-jumptrading
force-pushed
the
ibhatt/unwind_banks_cow
branch
from
b3d73e5 to
0f2b75a
Compare
ibhatt-jumptrading
changed the title
ibhatt-jumptrading
changed the title
ibhatt-jumptrading
changed the title
ripatel-fd
reviewed
Jan 7, 2026
| /**/ fd_topob_tile_uses( topo, &topo->tiles[ fd_topo_find_tile( topo, "replay", 0UL ) ], banks_obj, FD_SHMEM_JOIN_MODE_READ_WRITE ); | ||
| /**/ fd_topob_tile_uses( topo, &topo->tiles[ fd_topo_find_tile( topo, "tower", 0UL ) ], banks_obj, FD_SHMEM_JOIN_MODE_READ_WRITE ); | ||
| FOR(exec_tile_cnt) fd_topob_tile_uses( topo, &topo->tiles[ fd_topo_find_tile( topo, "exec", i ) ], banks_obj, FD_SHMEM_JOIN_MODE_READ_WRITE ); /* TODO: Should be readonly? */ | ||
| FOR(exec_tile_cnt) fd_topob_tile_uses( topo, &topo->tiles[ fd_topo_find_tile( topo, "exec", i ) ], banks_obj, FD_SHMEM_JOIN_MODE_READ_WRITE ); |
Contributor
There was a problem hiding this comment.
In the future it would be nice to separate out the bank into parts that are directly modified by exec tiles (e.g. lthash and other commit stuff), and read-only stuff (where exec tiles only take read locks)
Contributor
Author
There was a problem hiding this comment.
working on a follow up that splits out locks from the banks data atm
ripatel-fd
reviewed
Jan 7, 2026
ripatel-fd
reviewed
Jan 7, 2026
| static inline void | ||
| fd_bank_set_epoch_rewards_pool_lock( fd_bank_t * bank, fd_rwlock_t * rwlock ) { | ||
| bank->epoch_rewards_pool_lock_offset = (ulong)rwlock - (ulong)bank; | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we need this? Can't we just make this rwlock a regular struct member?
Contributor
Author
There was a problem hiding this comment.
the locks are shared with each fd_bank_t and the fd_banks_t so it can't be a struct member of the fd_bank_t we also can't use pointers because the bank/banks are all in different tiles
ripatel-fd
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.