fix: --wait no longer hangs on self-hosted instances#75
Open
Luc0-0 wants to merge 1 commit intofirecrawl:mainfrom
Open
fix: --wait no longer hangs on self-hosted instances#75Luc0-0 wants to merge 1 commit intofirecrawl:mainfrom
Luc0-0 wants to merge 1 commit intofirecrawl:mainfrom
Conversation
--wait without --progress delegates to app.crawl(), the SDK's built-in convenience method. On self-hosted deployments this hangs indefinitely because the SDK's internal polling mechanism is incompatible with self-hosted API instances. --wait --progress already works correctly because it uses a manual getCrawlStatus() polling loop. This change makes --wait alone take the same code path, removing the app.crawl() branch entirely. Behaviour is unchanged for cloud API users. Progress output to stderr is still gated behind the --progress flag. Fixes #3210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
firecrawl crawl <url> --waithangs indefinitely when used against a self-hosted Firecrawl instance unless--progressis also passed.Closes #3210
Root cause
The
--waitpath (without--progress) delegated toapp.crawl()— the SDK's built-in convenience method that starts the crawl and waits internally. On self-hosted deployments this hangs because the SDK's polling mechanism is incompatible with self-hosted API instances.The
--wait --progresspath already worked correctly because it used a manualgetCrawlStatus()polling loop.Fix
Removed the
app.crawl()branch. Both--waitand--wait --progressnow go through the samestartCrawl→getCrawlStatuspolling loop. Progress output to stderr is still gated behind--progress.Testing
--waitnow usesstartCrawl+getCrawlStatusinstead ofapp.crawl()--waitdoes not write progress to stderr--waitreturns timeout error correctly when crawl exceeds timeout