Final code for Chezy #122
Open
Final code for Chezy #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scape into chezy-anthony-improved-logs
Nutella399
reviewed
Nov 18, 2025
| private final RobotContainer m_robotContainer; | ||
| private VisionSystem visionRight; | ||
| private VisionSystem visionLeft; | ||
| private AnthonyVision visionRight; |
Contributor
There was a problem hiding this comment.
can we rename the class pls
| */ | ||
| public class AnthonyVision extends SubsystemBase { | ||
| // static member of AnthonyVision that contains array of all existing AnthonyVision systems | ||
| private static AnthonyVision[] systemList = |
Contributor
There was a problem hiding this comment.
why do we need an array of exisitng vision systems?
| @Override | ||
| public void periodic() { | ||
| // Initialize swerve drive if not already done | ||
| if (swerveDrive == null) { |
Contributor
There was a problem hiding this comment.
why are we initializing in periodic?
| List<PhotonPipelineResult> results = photonCamera.getAllUnreadResults(); | ||
|
|
||
| // Go through all results (if there are any) and update the latest result with the last | ||
| for (var result : results) { |
Contributor
There was a problem hiding this comment.
do we need to interate if this is effectively grabbing the last value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.