-
Notifications
You must be signed in to change notification settings - Fork 613
feat(go): added support for embedding prompts into the binary #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @apascal07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Go Genkit framework by enabling the embedding of AI prompts directly into application binaries. This feature leverages Go's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the ability to load prompts from an embedded filesystem (io/fs.FS) in addition to the existing disk-based loading. Key changes include new LoadPromptFS functions in go/ai/prompt.go and go/genkit/genkit.go, a WithPromptFS option for genkit.Init, and refactoring of prompt loading logic. Comprehensive tests for the new embedded filesystem functionality have been added, along with a new sample (go/samples/prompts-embed) demonstrating its usage. The review comment points out an error in this new sample, where genkit.WithPromptFS is incorrectly called with two arguments; the root directory for embedded prompts should instead be specified using genkit.WithPromptDir in conjunction with WithPromptFS.
Fixes #3214 and #3746.
Checklist (if applicable):