-
Notifications
You must be signed in to change notification settings - Fork 614
feat(go): implement load prompt from source #3965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josearomeroj
wants to merge
1
commit into
firebase:main
Choose a base branch
from
josearomeroj:implement_load_prompt_from_source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -123,3 +123,21 @@ func TestDefineSchemaWithType_Error(t *testing.T) { | |||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| DefineSchemaFor[Invalid](g) | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| func TestLoadPromptFromSource(t *testing.T) { | ||||||||||||||||||||||||
| g := Init(t.Context()) | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| source := `--- | ||||||||||||||||||||||||
| model: test/model | ||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||
| Hello` | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| p := LoadPromptFromSource(g, source, "testPrompt", "testNamespace") | ||||||||||||||||||||||||
| if p == nil { | ||||||||||||||||||||||||
| t.Fatal("LoadPromptFromSource returned nil") | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| if p.Name() != "testNamespace/testPrompt" { | ||||||||||||||||||||||||
| t.Errorf("got name %q, want %q", p.Name(), "testNamespace/testPrompt") | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
Comment on lines
+142
to
+143
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test covers the successful creation of a prompt. It would be beneficial to also test the failure case, for instance, when the provided source is invalid. This ensures the wrapper function correctly propagates the nil return on error.
Suggested change
|
||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test for
TestLoadPromptFromSourceis great for the happy paths. To make it more robust, consider adding a test case for when an invalid prompt source is provided. This will ensure that the function correctly handles errors and returnsnilas expected.For example, you could add a check for a source with an unclosed template variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot add a test case that expects LoadPromptFromSource to return nil for invalid template syntax (like an unclosed variable) because the underlying dotprompt library performs parsing loosely at load time. It does not validate the template syntax during Parse, so LoadPromptFromSource successfully returns a Prompt object. The error would only occur later during execution (e.g., when Render is called).