Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,12 @@ public FlutterFirebaseFirestoreException(
}
}

if (nativeException != null
&& nativeException.getMessage() != null
&& !nativeException.getMessage().isEmpty()) {
message = nativeException.getMessage();
}

this.code = code;
this.message = message;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,30 @@ void runDocumentReferenceTests() {
});

group('DocumentReference.get()', () {
test(
'preserves native error messages when offline',
() async {
final document =
await initializeTest('document-get-server-while-offline');
await firestore.disableNetwork();
addTearDown(firestore.enableNetwork);

await expectLater(
document.get(const GetOptions(source: Source.server)),
throwsA(
isA<FirebaseException>()
.having((error) => error.code, 'code', 'unavailable')
.having(
(error) => error.message,
'message',
contains('offline'),
),
),
);
},
skip: kIsWeb,
);

test('gets a document from server', () async {
DocumentReference<Map<String, dynamic>> document =
await initializeTest('document-get-server');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ + (NSArray *)ErrorCodeAndMessageFromNSError:(NSError *)error {
break;
}

if (error.localizedDescription.length > 0) {
message = error.localizedDescription;
}

return @[ code, message ];
}

Expand Down
Loading