Draft
Conversation
…ting- update dependencies- bump node version
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the repository by upgrading dependencies, migrating to Node.js 20, replacing TSLint with Biome, and updating function code and tests to use the new runtime and APIs.
- Remove legacy tslint config and switch to Biome for linting/formatting
- Update dependencies and scripts (Node 20 runtime, Firestore/Storage client versions, Jest/Biome configs)
- Refactor Cloud Function imports, storage path logic, and convert tests from axios to native fetch
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| functions/tslint.json | Removed (replaced by Biome) |
| functions/tsconfig.json | Dropped Jest types from production build |
| functions/src/index.ts | Updated imports, storagePath logic, onRequest handler signature |
| functions/src/build_bundle.ts | Added trailing commas, switched to import type |
| functions/package.json | Bumped dependencies, switched lint/build/test scripts |
| functions/jest.config.js | Replaced globals with transform syntax |
| functions/biome.json | Added Biome configuration |
| functions/tests/*.test.ts | Converted tests from axios to fetch, unskipped some tests |
| extension.yaml | Migrated Firebase Function runtime to Node.js 20 |
| _emulator/firebase.json | Added functions emulator port |
Comments suppressed due to low confidence (2)
functions/src/index.ts:76
- Consider adding a unit test for
storagePathwhen the query string is empty to verify that no trailing?is appended.
const queryString = sortQuery(query);
functions/src/index.ts:54
- [nitpick] The
filterQueryfunction is defined but not currently used; consider removing it or integrating its logic where needed to reduce dead code.
function filterQuery(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a catch-all PR to do a few things:
I will break this PR up into smaller atomic ones for easier review, and keep this as a draft for now.