Analytics: Add apple store kit 2 support#1460
Conversation
AustinBenoit
added
the
tests-requested: full
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Apple's StoreKit 2 transactions in Firebase Analytics by adding the LogAppleTransactionAsync method. The update includes necessary SWIG configurations for async support, a new UI test button and automated test case in the sample app, and detailed documentation for iOS testing. Review feedback primarily identified several typos and capitalization issues in the C# documentation, the test app readme, and the release notes.
| /// </summary> | ||
| /// <remarks> | ||
| /// This method is intended for Unity developers on iOS who process transactions | ||
| /// via In-app purchases and need whish to log those purchases through Google Analytics. |
There was a problem hiding this comment.
There is a typo in the documentation: 'need whish' should be corrected to 'wish'.
/// via In-app purchases and wish to log those purchases through Google Analytics. | /// This method is intended for Unity developers on iOS who process transactions | ||
| /// via In-app purchases and need whish to log those purchases through Google Analytics. | ||
| /// The provided ID must map 1:1 with the native Apple `Transaction.id`. | ||
| /// If a matching transaction is not found in the apple devices purchase history then |
There was a problem hiding this comment.
Proper nouns like 'Apple' should be capitalized, and 'device's' should be possessive to correctly describe the purchase history.
/// If a matching transaction is not found in the Apple device's purchase history then |
|
||
| ## iOS Testing LogAppleTransaction | ||
|
|
||
| To test the log apple transaction function, you should use the exported Xcode project and Xcode's simulated transactions. |
There was a problem hiding this comment.
The method name 'LogAppleTransaction' and the proper noun 'Apple' should be capitalized for consistency and clarity.
| To test the log apple transaction function, you should use the exported Xcode project and Xcode's simulated transactions. | |
| To test the LogAppleTransaction function, you should use the exported Xcode project and Xcode's simulated transactions. |
| ------------- | ||
| ### Upcoming | ||
| - Changes | ||
| - Analytics: Add support for Apple's Store kit 2 transactions. Add new `LogAppleTransactionAsync` method |
There was a problem hiding this comment.
The correct name for the framework is 'StoreKit 2'. Also, there is an extra space before the method name that should be removed.
| - Analytics: Add support for Apple's Store kit 2 transactions. Add new `LogAppleTransactionAsync` method | |
| - Analytics: Add support for Apple's StoreKit 2 transactions. Add new `LogAppleTransactionAsync` method |
1 participant
Description
Analytics: Add apple store kit 2 support for logging apple transactions.
Testing
Test locally with simulator and simulated Apple transaction:
Added in additional integration tests to validate the other platforms are error free.
Type of Change
Place an
xthe applicable box: