add support for additional Next.js config file types#9871
add support for additional Next.js config file types#9871
Conversation
- Updated CONFIG_FILES to include "next.config.ts" and "next.config.mts". - Modified logic in ɵcodegenFunctionsDirectory to handle new config file types. - Added unit tests for whichNextConfigFile to ensure correct file detection and prioritization.
Summary of ChangesHello @leoortizz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firebase CLI's compatibility with Next.js projects by introducing support for TypeScript-based configuration files. It ensures that projects using Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for TypeScript-based Next.js configuration files (next.config.ts and next.config.mts). The changes are well-implemented across the codebase. The CONFIG_FILES constant is updated, the function ɵcodegenFunctionsDirectory is modified to correctly transpile TypeScript config files for the Cloud Functions environment, and new unit tests have been added to verify the config file detection logic. The changes look solid and improve the framework's flexibility.
Description
Might fix #9854
Scenarios Tested
firebase deploywith Next.js projects usingnext.config.tsandnext.config.mtsSample Commands
firebase deploy