Skip to content

fix(eventarc): set eventTrigger.region from channel to prevent unnecessary delete+recreate on deploy #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepfotello wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(eventarc): set eventTrigger.region from channel to prevent unnecessary delete+recreate on deploy #1855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/v2/providers/eventarc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ export function onCustomEventPublished<T = any>(
func.run = handler;

const channel = opts.channel ?? "locations/us-central1/channels/firebase";
const channelRegionMatch = channel.match(/locations\/([^/]+)\/channels\//);
const triggerRegion = channelRegionMatch ? channelRegionMatch[1] : "us-central1";
Comment on lines +204 to +205
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex used to extract the region from the channel string is brittle. If the channel format changes or if the input does not match the expected pattern, it defaults to 'us-central1' silently. It would be safer to validate the channel format or use a more robust parsing method to avoid incorrect region assignment.


const baseOpts = options.optionsToEndpoint(options.getGlobalOptions());
const specificOpts = options.optionsToEndpoint(opts);
Expand All @@ -219,6 +221,7 @@ export function onCustomEventPublished<T = any>(
eventFilters: {},
retry: opts.retry ?? false,
channel,
region: triggerRegion,
},
};
convertIfPresent(endpoint.eventTrigger, opts, "eventFilters", "filters");
Expand Down