Skip to content

Conversation

@jonathanedey
Copy link
Contributor

Allows the admin SDK to enqueue and delete tasks within the locally running cloud tasks emulator to provide for easier testing.

RELEASE NOTES: Enabled support for interacting with the Cloud Task emulator when the CLOUD_TASKS_EMULATOR_HOST environment variable is set.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jonathanedey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Cloud Task Queue Emulator support into the Firebase Admin Python SDK. This enhancement allows developers to seamlessly test task queue functionalities locally by configuring an environment variable, thereby streamlining the development workflow and reducing reliance on live cloud deployments for testing.

Highlights

  • Cloud Task Queue Emulator Support: The Admin SDK now supports interacting with the Cloud Tasks emulator, enabling local testing of task queue operations.
  • Environment Variable Activation: Emulator support is activated by setting the CLOUD_TASKS_EMULATOR_HOST environment variable.
  • Credential Handling: When the emulator is active, _utils.EmulatorAdminCredentials() are used, and a default service account email is provided for OIDC tokens.
  • API Payload Adjustments: The Task object now includes a _to_api_dict() method for proper serialization, and API field names like oidc_token, schedule_time, and dispatch_deadline have been updated to oidcToken, scheduleTime, and dispatchDeadline respectively for consistency.
  • URL Routing: Task enqueue and delete operations dynamically route requests to the emulator host if the environment variable is set, otherwise, they use the production Cloud Tasks API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Cloud Task Queue Emulator, which is a valuable addition for local development and testing. The implementation correctly detects the emulator environment and adapts the API requests. The refactoring to use _to_api_dict for payload creation is a nice improvement for clarity and correctness. I have identified a couple of issues: a potential runtime error when parsing the emulator's response, and a missing input validation in the delete method which appears to be a regression. I've also suggested a small performance optimization to cache the environment variable lookup. Overall, this is a solid contribution with comprehensive tests for the new functionality.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Nov 25, 2025
@jonathanedey jonathanedey merged commit 2305519 into master Dec 3, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'Credentials' object has no attribute 'service_account_email'

2 participants