chore(deps): upgrade lerna to v9.0.7 and resolve vulnerabilities without npm workspaces#2906
Open
inlined wants to merge 2 commits into
Open
chore(deps): upgrade lerna to v9.0.7 and resolve vulnerabilities without npm workspaces#2906inlined wants to merge 2 commits into
inlined wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the repository to npm workspaces, updates Lerna to version 9.0.7, and configures skipLibCheck in several TypeScript configurations. Feedback on these changes highlights two critical issues: first, the auth-mailchimp-sync/functions package was accidentally omitted from the new workspaces array in package.json; second, the generate-package-locks script needs to be updated with --workspaces=false to prevent npm from updating the root lockfile instead of generating individual workspace lockfiles.
c7c4838 to
144b96b
Compare
144b96b to
0da5713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit & Remediation: extensions
A. Previous CVEs
tar(Severity: High)js-yaml(Severity: Moderate)tough-cookie(Severity: Moderate)lodash(Severity: High)glob,uuid, etc.).B. Changes Made
lernafrom3.4.3to9.0.7in rootpackage.json.package.jsonto force secure versions of transitive dependencies:tar:^7.5.16js-yaml:^4.2.0tough-cookie:^4.1.3lodash:^4.17.21scripts/bootstrap.js) to handle local linking of internal package dependencies without using npm workspaces.postinstallscript in the rootpackage.jsonto run the custom bootstrapping script instead of the deprecatedlerna bootstrap."skipLibCheck": trueto the TypeScript configurations offirestore-shorten-urls-bitly/functionsandrtdb-limit-child-nodes/functionsto bypass type resolution errors.C. Remaining CVEs
D. Introduced CVEs
E. Testing Strategy
npm run build).npm run lintsuccessfully.