Skip to content

test: SwiftUI integration tests and View tests for create user and sign-in#1257

Merged
russellwheatley merged 39 commits into
mainfrom
swiftui-tests
May 28, 2025
Merged

test: SwiftUI integration tests and View tests for create user and sign-in#1257
russellwheatley merged 39 commits into
mainfrom
swiftui-tests

Conversation

@russellwheatley

@russellwheatley russellwheatley commented May 16, 2025

Copy link
Copy Markdown
Member
  • unit tests/integration tests for AuthService.
  • UI tests on Views for create user, sign-in flows and navigation between Views.

@russellwheatley russellwheatley changed the title chore: delete benchmark file test: SwiftUI integration tests and View tests for create user and sign-in May 16, 2025
Comment thread .github/workflows/swiftui-auth.yml Fixed
Comment thread .github/workflows/swiftui-auth.yml Fixed
@russellwheatley russellwheatley marked this pull request as ready for review May 22, 2025 07:51

@morganchen12 morganchen12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit or two.

actionCodeSettings.setIOSBundleID(Bundle.main.bundleIdentifier!)
let configuration = AuthConfiguration(
shouldAutoUpgradeAnonymousUsers: true,
shouldAutoUpgradeAnonymousUsers: uiAuthEmulator ? false : true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be written as !uiAuthEmulator

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@russellwheatley russellwheatley merged commit 017479f into main May 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants