feat: utilise tosURL and privacyPolicyUrl. make nullable#1254
Merged
Conversation
morganchen12
approved these changes
May 12, 2025
| let tosUrl: URL | ||
| let privacyPolicyUrl: URL | ||
| let tosUrl: URL? | ||
| let privacyPolicyUrl: URL? |
Contributor
There was a problem hiding this comment.
nit: with the behavior in the view rendering an empty view if one but not both are set, we should document that both these properties need to be set in order to render a privacy and terms footer.
Member
Author
There was a problem hiding this comment.
Good catch, I've updated README here: 37903bd (#1254)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tosURLandprivacyPolicyUrlnullable as discussed in previous meeting, up to user to define.