-
Notifications
You must be signed in to change notification settings - Fork 150
fix: misleading endpoint status codes and error messages #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misleading endpoint status codes and error messages #1293
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 80.85% 80.88% +0.02%
==========================================
Files 66 65 -1
Lines 4514 4546 +32
Branches 778 777 -1
==========================================
+ Hits 3650 3677 +27
- Misses 849 854 +5
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I double-checked that the frontend status code handlers are still working. Since we removed a bunch of false 401 errors, most of these would get caught by the generic handler instead. Of course, we should make these more descriptive by showing the actual error message and status code and removing the callback-based error handling entirely. This is captured in #1188 |
kriswest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
Thanks for the review @kriswest! |
Fixes #1285. Based on #1202, would love to get that one merged first!