Skip to content

Conversation

@jescalada
Copy link
Contributor

@jescalada jescalada commented Nov 28, 2025

Fixes #1285. Based on #1202, would love to get that one merged first!

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 72b0eda
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69395eb4c733d000080334b4

@github-actions github-actions bot added the fix label Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 72.18935% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (7e625cd) to head (72b0eda).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/service/routes/push.ts 70.14% 20 Missing ⚠️
src/service/routes/auth.ts 77.64% 19 Missing ⚠️
src/service/routes/users.ts 14.28% 6 Missing ⚠️
src/service/routes/utils.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
+ Coverage   80.85%   80.88%   +0.02%     
==========================================
  Files          66       65       -1     
  Lines        4514     4546      +32     
  Branches      778      777       -1     
==========================================
+ Hits         3650     3677      +27     
- Misses        849      854       +5     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada
Copy link
Contributor Author

I double-checked that the frontend status code handlers are still working. Since we removed a bunch of false 401 errors, most of these would get caught by the generic handler instead.

Of course, we should make these more descriptive by showing the actual error message and status code and removing the callback-based error handling entirely. This is captured in #1188

@jescalada jescalada requested review from a team and kriswest November 30, 2025 07:25
@kriswest kriswest changed the base branch from main to 1150-vitest-migration-from-service December 1, 2025 17:05
@kriswest kriswest changed the base branch from 1150-vitest-migration-from-service to main December 1, 2025 17:05
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jescalada and others added 2 commits December 10, 2025 11:51
Co-authored-by: Kris West <kristopher.west@natwest.com>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada
Copy link
Contributor Author

Thanks for the review @kriswest!

@jescalada jescalada enabled auto-merge December 10, 2025 11:52
@jescalada jescalada merged commit 5d1a727 into finos:main Dec 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve endpoint status codes (/src/service/routes)

2 participants