DRV-22: Consistent property sync and release workflow#16
Merged
Conversation
svc-finitelabs
Bot
force-pushed
the
fix/DRV-22-consistent-sync-pattern
branch
from
33ca4b7 to
b9d1fec
Compare
svc-finitelabs
Bot
changed the title
svc-finitelabs
Bot
force-pushed
the
fix/DRV-22-consistent-sync-pattern
branch
2 times, most recently
from
f25063f to
b641e2d
Compare
Contributor
Author
|
CI is green now. The original failure was on commit Note: the Makefile's |
- Use SetDeviceProperties utility for property sync (consistent with all drivers) - Glob zip files in release workflow (no hardcoded repo name)
svc-finitelabs
Bot
force-pushed
the
fix/DRV-22-consistent-sync-pattern
branch
from
556efee to
8943f86
Compare
added 2 commits
March 26, 2026 07:12
Property sync already works in the released version — this change is about consistency with the other drivers, not a bug fix.
The build regenerates README.md via pandoc, which wraps lines at ~72 columns. The changelog entry exceeded that limit, causing a dirty-tree diff in CI.
svc-finitelabs
Bot
force-pushed
the
fix/DRV-22-consistent-sync-pattern
branch
from
d1e735c to
3607203
Compare
derek-miller
approved these changes
Mar 26, 2026
svc-finitelabs Bot
added a commit
that referenced
this pull request
Mar 31, 2026
* DRV-22: Consistent property sync and release workflow - Use SetDeviceProperties utility for property sync (consistent with all drivers) - Glob zip files in release workflow (no hardcoded repo name) * fix: update changelog wording per review feedback Property sync already works in the released version — this change is about consistency with the other drivers, not a bug fix. * fix: pre-wrap changelog line to pass dirty-tree check The build regenerates README.md via pandoc, which wraps lines at ~72 columns. The changelog entry exceeded that limit, causing a dirty-tree diff in CI. * fix: reset README.md (auto-generated by build) * chore: regenerate README after build * fix: revert changelog entry per review — user-facing changes only * fix: remove Unreleased changelog section — no user-facing changes ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns influxdb driver with the consistent patterns used across all OSS drivers.
Changes
SendUIRequest/GetDevicePropertieswithSetDeviceProperties()utility fromsrc/lib/utils.lua*.zipinstead of hardcodedcontrol4-influxdb.zipAddresses DRV-22