Skip to content

Migrate to changesets#335

Merged
TheUnderScorer merged 12 commits into
mainfrom
build/migrate-to-changesets
Mar 25, 2026
Merged

Migrate to changesets#335
TheUnderScorer merged 12 commits into
mainfrom
build/migrate-to-changesets

Conversation

@TheUnderScorer
Copy link
Copy Markdown
Contributor

@TheUnderScorer TheUnderScorer commented Mar 10, 2026

  • Migrated from semantic-release to changesets
  • Renamed package name to @fingerprint/aws-cloudfront-proxy
  • Updated invalid pnpm-workspace.yaml to correct paths

@TheUnderScorer TheUnderScorer self-assigned this Mar 10, 2026
@TheUnderScorer TheUnderScorer force-pushed the build/migrate-to-changesets branch from a3bddcf to 6709bf8 Compare March 10, 2026 10:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 92.41% 694/751
🟢 Branches 85.64% 167/195
🟢 Functions 90.71% 127/140
🟢 Lines 92.56% 659/712

Test suite run success

209 tests passing in 21 suites.

Report generated by 🧪jest coverage report action from 72a3b4b

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 92.41 85.64 90.71 92.55
🟢  mgmt-lambda 98.93 93.33 100 98.93
🟢   DefaultSettings.ts 100 100 100 100
🟢   app.ts 97.91 95 100 97.91 26
🟢   auth.ts 100 100 100 100
🟢   exceptions.ts 100 66.66 100 100 20
🟢   routing.ts 100 100 100 100
🟢  mgmt-lambda/handlers 87.22 72.5 93.33 87.15
🟢   errorHandlers.ts 100 71.42 100 100 22,41
🟡   statusHandler.ts 80 50 100 80 76-80,84-89
🟢   updateHandler.ts 87.21 75.86 87.5 87.12 50-51,67-68,139-142,214,219-228,290-291,319
🟢  mgmt-lambda/utils 81.25 88.88 66.66 100
🟢   cloudfrontUtils.ts 100 88.88 100 100 6
🔴   delay.ts 40 100 0 100
🟢  proxy/handlers 98.36 95.45 100 98.36
🟢   handleIngress.ts 97.43 91.66 100 97.43 63
🟢   handleStatus.ts 100 100 100 100
🟡  proxy/test 77.77 100 50 71.42
🟡   aws.ts 77.77 100 50 71.42 4-5
🟢  proxy/test/utils/customer-variables 100 100 100 100
🟢   in-memory-customer-variables.ts 100 100 100 100
🟢  proxy/utils 90.08 80.32 88.23 89.9
🟢   buffer.ts 100 100 100 100
🟢   cache-control.ts 100 100 100 100
🟢   cookie.ts 100 100 100 100
🔴   generateErrorResponse.ts 23.07 100 25 25 15-30
🟢   headers.ts 100 100 100 100
🔴   is-blob.ts 0 0 0 0 6-7
🟢   log.ts 85.71 33.33 100 83.33 11
🟢   paths.ts 100 87.5 100 100 19
🟢   request.ts 93.1 66.66 83.33 90.9 7-8
🟢   routing.ts 100 100 100 100
🔴   string.ts 14.28 100 0 14.28 2-8
🟢   traffic.ts 100 100 100 100
🟢   transport.ts 93.1 62.5 100 93.1 33,58
🟢  proxy/utils/customer-variables 98.79 88.88 95.45 98.52
🟢   customer-variables.ts 100 100 100 100
🟢   defaults.ts 100 100 100 100
🟢   header-customer-variables.ts 100 100 100 100
🟢   maybe-obfuscate-variable.ts 100 100 100 100
🟢   selectors.ts 96.66 100 90 94.11 22
🟢   types.ts 100 75 100 100 19
🟢  proxy/utils/customer-variables/secrets-manager 95.58 100 100 95.52
🟢   normalize-secret.ts 100 100 100 100
🟢   retrieve-secret.ts 100 100 100 100
🟢   secrets-manager-variables.ts 86.95 100 100 86.95 28,50-55
🟢   validate-secret.ts 100 100 100 100

@TheUnderScorer TheUnderScorer force-pushed the build/migrate-to-changesets branch from 6709bf8 to ca418dc Compare March 10, 2026 10:07
@TheUnderScorer TheUnderScorer force-pushed the build/migrate-to-changesets branch from ca418dc to ff1b644 Compare March 10, 2026 10:09
@TheUnderScorer TheUnderScorer marked this pull request as ready for review March 10, 2026 10:10
@TheUnderScorer TheUnderScorer force-pushed the build/migrate-to-changesets branch from 61a2186 to 91fde14 Compare March 10, 2026 15:27
Comment thread .github/workflows/release.yml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the repo’s release process from semantic-release to Changesets, updates the published package name, and adjusts CI/workspace configuration to support the new release flow (including uploading built ZIP artifacts to GitHub Releases).

Changes:

  • Replace semantic-release config with Changesets config + workflows (versioning/publishing + preview).
  • Rename the root package to @fingerprint/cloudfront-proxy and add Changesets-related scripts/deps.
  • Update workspace + CI/release workflows (Node version via .node-version, build:release, release asset upload job).

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
scripts/uploadReleaseAsset.cjs New GitHub Script helper to delete/re-upload release assets (ZIPs) for a release.
pnpm-workspace.yaml Adjust workspace package globs to include root and e2e/*.
pnpm-lock.yaml Lockfile updates for Changesets and new transitive deps.
package.json Rename package, add build:release, and add Changesets scripts/deps.
e2e/tests/package.json Add a version to support workspace/release tooling expectations.
.releaserc Remove semantic-release configuration.
.node-version Bump Node version to 24 for CI/tooling alignment.
.github/workflows/terraform-e2e-tests-on-dev.yml Use .node-version and build:release in E2E workflow.
.github/workflows/release.yml Switch reusable workflow to the Changesets-based release workflow.
.github/workflows/publish-lambda.yml Add an upload-assets job to upload built ZIPs to GitHub Release assets before running E2Es.
.github/workflows/analyze-commits.yml Add Changesets preview workflow job and disable previewNotes in commit analysis job.
.changeset/pre.json Configure prerelease mode for rc tag.
.changeset/config.json Add Changesets configuration (changelog formatter, baseBranch, ignored packages, etc.).
.changeset/cold-needles-warn.md Add a Changeset entry for a minor bump.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/publish-lambda.yml Outdated
Comment thread .github/workflows/publish-lambda.yml Outdated
Comment thread .changeset/config.json
Comment thread .changeset/config.json Outdated
Comment thread scripts/uploadReleaseAsset.cjs Outdated
Comment thread scripts/uploadReleaseAsset.cjs Outdated
Comment thread scripts/uploadReleaseAsset.cjs Outdated
Comment thread scripts/uploadReleaseAsset.cjs Outdated
Comment thread scripts/uploadReleaseAsset.cjs Outdated
Comment thread scripts/uploadReleaseAsset.cjs Outdated
Comment thread pnpm-workspace.yaml
Comment thread .github/workflows/analyze-commits.yml Outdated
TheUnderScorer and others added 2 commits March 24, 2026 11:09
Co-authored-by: Dan McNulty <212590662+mcnulty-fp@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/aws-cloudfront-proxy@2.2.0-rc.0

Minor Changes

Bug Fixes

  • bundle AWS SDKs inside Lambda functions to avoid runtime issues (95f8d78)

mcnulty-fp
mcnulty-fp previously approved these changes Mar 24, 2026
Base automatically changed from feature/use-warden-for-cdn to main March 25, 2026 09:05
@TheUnderScorer TheUnderScorer dismissed mcnulty-fp’s stale review March 25, 2026 09:05

The base branch was changed.

@TheUnderScorer TheUnderScorer merged commit 8682b29 into main Mar 25, 2026
8 of 9 checks passed
@TheUnderScorer TheUnderScorer deleted the build/migrate-to-changesets branch March 25, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants