Hash consing#385
Open
ricky122-5 wants to merge 3 commits into
Open
Conversation
willow-ahrens
requested changes
Apr 28, 2026
Member
willow-ahrens
left a comment
willow-ahrens
left a comment
There was a problem hiding this comment.
Term should inherit from hashCons, and TermTree should define hash_key
| hash_cons_table[key] = obj | ||
| return obj | ||
| except TypeError: | ||
| return object.__new__(cls) |
| return (type(a), a) | ||
|
|
||
|
|
||
| class HashCons: |
Member
There was a problem hiding this comment.
Add an abstractmethod called Hash_keys which defines which keys are used in the hashcons object
| _sig_cache: dict = {} | ||
|
|
||
|
|
||
| def _key_part(a: object) -> object: |
Member
There was a problem hiding this comment.
This method would be disaggregated across child classes of HashCons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds hash consing to finch-lite.
Implements hash consing across all 5 IR node hierarchies, so structurally equal nodes now return the same object via a WeakValueDictionary intern table. Intercepts construction in new so both direct calls and rewriter paths are covered. Fixed a few subtle bugs along the way: Literal(0) and Literal(0.0) colliding due to Python's hash(0) == hash(0.0), a GC bug from storing into a weak dict without a local strong ref, and a traversal test that assumed unique node identities.