Add a site footer linking to the author and the repo#10
Conversation
Adds a saloon-styled footer in the shared Layout with links to the author's GitHub profile (@finallyjay) and the project source on GitHub. Makes <body> a flex column with <main> growing so the footer sits at the bottom on short pages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughA site footer is added to the page layout beneath the main content, containing attribution text and a link to the GitHub repository. The page structure is updated to use flexbox layout to ensure the footer stays at the bottom of the viewport. ChangesSite Footer Feature
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Comment |
There was a problem hiding this comment.
Pull request overview
Adds a persistent “saloon”-styled site footer to the shared Layout, including attribution and a source link, and updates global layout CSS so the footer sticks to the bottom on short pages.
Changes:
- Make
bodya flex column and allowmainto grow so the footer can sit at the bottom of the viewport. - Add a new footer to
Layout.astrowith links to the author profile and the GitHub repository. - Add component-layer CSS styles for the footer to match the existing topbar styling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/styles/global.css |
Updates page-level flex layout and adds styling for the new .sitefoot footer. |
src/layouts/Layout.astro |
Adds the footer markup (credit + source links) to the shared layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/styles/global.css (1)
392-392: ⚡ Quick winUse lowercase
currentcolorper CSS convention.CSS keyword values should be lowercase per the spec. Stylelint flagged this for consistency.
🎨 Proposed fix
- fill: currentColor; + fill: currentcolor;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/styles/global.css` at line 392, The CSS declaration uses the keyword with incorrect casing: change the fill property's value from "currentColor" to the lowercase "currentcolor" in the global.css rule (look for the fill: currentColor; declaration) so it matches CSS spec and resolves the stylelint warning.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/styles/global.css`:
- Line 392: The CSS declaration uses the keyword with incorrect casing: change
the fill property's value from "currentColor" to the lowercase "currentcolor" in
the global.css rule (look for the fill: currentColor; declaration) so it matches
CSS spec and resolves the stylelint warning.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ce1dfb75-8c66-4db3-b439-73d842fd952c
📒 Files selected for processing (2)
src/layouts/Layout.astrosrc/styles/global.css
Adds a saloon-styled footer to the shared
Layout, with:rel="noopener me")Layout:
<body>becomes a flex column and<main>grows (flex: 1) so the footer sticks to the bottom on short pages. Styling matches the existing topbar (dark bar, brass top border, Special Elite type).Verified locally: lint ✅, format:check ✅, build ✅, and visually checked the footer alignment.
🤖 Generated with Claude Code
Summary by CodeRabbit