PolicyConfig class to manipulate Windows audio devices#398
Open
astutejoe wants to merge 1 commit intofiloe:masterfrom
astutejoe:patch-1
Open
PolicyConfig class to manipulate Windows audio devices#398astutejoe wants to merge 1 commit intofiloe:masterfrom astutejoe:patch-1
astutejoe wants to merge 1 commit intofiloe:masterfrom
astutejoe:patch-1
Conversation
This class enables the programmer to manipulate Windows settings for audio devices, such as the default device for each role. It's rather messy due to the fact that the COM Interface IID changes with a considerable frequency, hence we need to try to support every possibility, falling back to an unknown interface (https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dcom/2b4db106-fb79-4a67-b45f-63654f19c54c) as a last resort. This class is basically a mashup of many different implementations of the same feature across public repositories, extracting, to my best judgment, the best of each. It's most probably not following the project code standards so I'm kinda expecting for someone to help me on that :) Sorry for any inconvenience!
Owner
|
Thanks for your pull request. cscore/CSCore/XAudio2/XAudio2_7.cs Line 100 in af1792e CSCore uses a special way of using com interfaces. I've wrote an article a few years ago: https://www.codeproject.com/Articles/644130/NET-COM-Interop-using-Postbuild The mentioned post compiler is already built into cscore. I would suggest to implement this the same way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class enables the programmer to manipulate Windows settings for audio devices, such as the default device for each role. It's rather messy due to the fact that the COM Interface IID changes with a considerable frequency, hence we need to try to support every possibility, falling back to an unknown interface (https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dcom/2b4db106-fb79-4a67-b45f-63654f19c54c) as a last resort. This class is basically a mashup of many different implementations of the same feature across public repositories, extracting, to my best judgment, the best of each. It's most probably not following the project code standards so I'm kinda expecting for someone to help me on that :)
Sorry for any inconvenience!