Fix: Launch files from jar archives#18554
Conversation
14ca6bf to
904af74
Compare
|
You should test your changes in Visual Studio https://files.community/docs/contributing/building-from-source what you put in the steps to test is not testing anything related to the change you have made |
|
This doesn't show the open with prompt for files with no program associated |
904af74 to
26df283
Compare
|
Good catch. I pushed The archive branch now keeps the direct Suggested manual checks for this PR:
Local checks:
|
|
Working for me |
Resolved / Related Issues
Summary
StorageFilerepresentation instead of passing the virtual archive path to the Win32 shell path.LauncherOptionswith the Files window handle for the archive-entry launch path, matching the nearby user-initiated launcher flows.Why
Files inside archives such as
.jarhave virtual paths likearchive.jar\path\File.class. Passing that path to the Win32 shell does not point at a real filesystem item, so double-clicking non-image files inside.jararchives can do nothing.ZipStorageFile.ToStorageFileAsync()already materializes archive entries as streamedStorageFileobjects, which is the launch path used for archive images.Steps used to test these changes
git diff --check.dotnet restore src\Files.App.Server\Files.App.Server.csproj -p:Platform=x64 --nologo.dotnet build src\Files.App\Files.App.csproj -c Debug -p:Platform=x64 --no-restore --nologo; the build reached the app XAML compilation stage, then failed withWMC9999because the local XAML compiler package could not loadMicrosoft.UI.Xaml.Markup.Compiler.ErrorMessages.resources.NavigationHelpers.OpenFile.