Fix: Update desktop Recycle Bin icon after bin operations (Fixes #9946)#18550
Open
myselfsiddharth wants to merge 1 commit into
Open
Fix: Update desktop Recycle Bin icon after bin operations (Fixes #9946)#18550myselfsiddharth wants to merge 1 commit into
myselfsiddharth wants to merge 1 commit into
Conversation
faabc67 to
6e03828
Compare
Call SHUpdateRecycleBinIcon after every recycle bin mutation so the Windows desktop icon reflects the current empty/full state. Fixes files-community#9946
6e03828 to
217467e
Compare
Member
|
Thank you for the PR. Unfortunately, the issue is still occurring on my end. Can you please upload a screen recording so I can follow the same steps you did on your end? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9946
Summary
The Windows desktop Recycle Bin icon now updates after recycle bin operations performed in Files.
UpdateDesktopRecycleBinIcon()toIStorageTrashBinServiceand implemented it inStorageTrashBinServiceusing the existingSHUpdateRecycleBinIconP/InvokeRestoreAllTrashesInternalto only refresh the icon and return success whenPerformOperationssucceedsTest plan