fix(hooks): unset GIT_DIR in pre-push so integration tests don't inherit it#25
Merged
laulauland merged 1 commit intomainfrom Apr 17, 2026
Merged
fix(hooks): unset GIT_DIR in pre-push so integration tests don't inherit it#25laulauland merged 1 commit intomainfrom
laulauland merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
git pushinvokeshooks/pre-push, git setsGIT_DIR=.gitin the env. That env var leaks intozig build test, and into every subprocess it spawns — including thegitcommands that integration tests run against temp repos (viahelpers.TempRepo). WithGIT_DIRset, those subprocessgitcalls operate on this repo's.gitinstead of the test's temp directory, which breaks at least one test (check from nested subdir with its own drift.lock only checks that scopeexpected exit 1, got 0).The hook passes when run directly but fails under
git push. This mismatch hit me while cutting the v0.9.0 release.Fix: unset
GIT_DIRat the top of the hook.