Add live data handling and update dependencies #300
+280
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Pasarus
requested changes
Feb 3, 2026
Member
Pasarus
left a comment
Pasarus
left a comment
There was a problem hiding this comment.
With the SSE, what happens when the user's session is still open and the API responsible restarts?
|
|
||
|
|
||
| # --- Live App Definition --- | ||
| live_app = FastAPI() |
Member
There was a problem hiding this comment.
Are we at the point this should be in a different file?
Collaborator
Author
There was a problem hiding this comment.
Maybe, it looks like the methods serve different purposes than the ones above it
Member
There was a problem hiding this comment.
It makes sense to me, perhaps a small refactor split them both out from the main file into specific router files under a routers package like in the main API?
Pasarus
reviewed
Feb 3, 2026
| ) as ws: | ||
| await ws.send(json.dumps({"type": "subscribe", "pvs": [pv]})) | ||
|
|
||
| while True: |
Member
There was a problem hiding this comment.
Should we have a timeout on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description