Vesuvio diff ip file #594
Vesuvio diff ip file #594
Conversation
…f_ip_file is not provided in the job inputs, it defaults to the value of ip_file
…-API into vesuvio_diff_ip_file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 96.12% 96.07% -0.06%
==========================================
Files 47 47
Lines 1780 1782 +2
==========================================
+ Hits 1711 1712 +1
- Misses 69 70 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| entity. | ||
| """ | ||
|
|
||
| #fmt: off |
There was a problem hiding this comment.
Why have you turned off the formatter here?
There was a problem hiding this comment.
the positioning of the #type: ignore kept getting moved by the automatic formatting and linting commit, or reported as unused, and for some reason Ruff, or mypy, has some type error (which was pre-existing to this change) with the job.inputs[], thinking it isn't indexable :/
Hence turning it off for this block, and then back on.
There was a problem hiding this comment.
Instead of turning off the formatter, please turn off mypy for those lines as mypy is the one failing.
…-API into vesuvio_diff_ip_file
Closes issue in autoreduction scripts, part of mini-EPIC for VESUVIO and fiaisis/autoreduction-scripts#50
Description