Skip to content

RFC: Add support for exporting in text format #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djeebus wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RFC: Add support for exporting in text format #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2075c1c
Add support for exporting in text format
djeebus Sep 5, 2016
101ebbd
Added chord names to tabs
djeebus Sep 5, 2016
90fe97d
Clean up the ends of lines before yielding them.
djeebus Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RocksmithToTab/CmdOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class CmdOptions
[Option('o', "outdir", DefaultValue = "rocksmith_tabs", HelpText = "Path to the directory where tabs should be created.")]
public string OutputDirectory { get; set; }

[Option('f', "format", DefaultValue = "gp5", HelpText = "File output format, currently either 'gp5', 'gpx' or 'gpif'.")]
[Option('f', "format", DefaultValue = "gp5", HelpText = "File output format, currently either 'gp5', 'gpx', 'gpif', or 'txt'")]
public string OutputFormat { get; set; }

[Option('n', "name", DefaultValue = "{artist} - {title}", HelpText = "Format of the output file names. For a list of available field names, refer to the readme.")]
Expand Down
5 changes: 5 additions & 0 deletions RocksmithToTab/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ static void ExportArrangement(Score score, Song2014 arrangement, string identifi

static GpxExporter gpxExporter = new GpxExporter();
static GP5File gp5Exporter = new GP5File();
static TxtExporter txtExporter = new TxtExporter();

static void SaveScore(Score score, string baseFileName, string outputDirectory, string outputFormat)
{
Expand All @@ -348,6 +349,10 @@ static void SaveScore(Score score, string baseFileName, string outputDirectory,
{
gpxExporter.ExportGpif(score, basePath + ".gpif");
}
else if (outputFormat == "txt")
{
txtExporter.ExportTxt(score, basePath + ".txt");
}
else
{
gpxExporter.ExportGPX(score, basePath + ".gpx");
Expand Down
3 changes: 2 additions & 1 deletion RocksmithToTabGUI/MainWindow.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion RocksmithToTabGUI/MainWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ private void CreateTabs_Click(object sender, EventArgs e)
return;
}

string[] fileFormats = new string[] { "gp5", "gpx", "gpif" };
string[] fileFormats = new string[] { "gp5", "gpx", "gpif", "txt" };
using (var callProgram = new CallProgram())
{
callProgram.RocksmithPath = RocksmithFolder.Text;
Expand Down
1 change: 1 addition & 0 deletions RocksmithToTabLib/RocksmithToTabLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="RhythmDetector.cs" />
<Compile Include="Score.cs" />
<Compile Include="TxtExporter.cs" />
<Compile Include="VersionInfo.cs" />
</ItemGroup>
<ItemGroup>
Expand Down
Loading