fix: skip MachineMixin init for Django historical models#561
Merged
fix: skip MachineMixin init for Django historical models#561
Conversation
Django's apps.get_model() creates historical model classes with __module__ = '__fake__' that don't carry user-defined class attributes like state_machine_name. Detect this and skip state machine initialization instead of raising ValueError. Closes #551
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #561 +/- ##
========================================
Coverage 99.77% 99.77%
========================================
Files 25 25
Lines 1751 1756 +5
Branches 229 230 +1
========================================
+ Hits 1747 1752 +5
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps.get_model()creates historical model classes with__module__ = '__fake__'that don't carry user-defined class attributes likestate_machine_nameMachineMixin.__init__now detects Django historical models and skips state machine initialization instead of raisingValueErrorstate_machine_nameis genuinely missingWhy not
deconstruct?Django's migration serializer uses
TypeSerializerfor base classes, which serializes by import path only — it never callsdeconstruct()on types. That mechanism only applies to field/validator instances.Closes #551