Skip to content

fix ConfigurationExtensions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashkandehnavi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ConfigurationExtensions #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/DotNet.Extensions.Configuration.Zookeeper/ZookeeperConfigurationExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ public static class ZookeeperConfigurationExtensions
/// <param name="rootPath">the zookeeper node path which you want to read it's sub node as key-value</param>
/// <param name="timeout">zookeeper session timeout in millsecond</param>
/// <param name="authInfo">authentication information to access keys on ZK</param>
public static void AddZookeeper(this IConfigurationBuilder builder,
public static IConfigurationBuilder AddZookeeper(this IConfigurationBuilder builder,
string connectionString, string rootPath, int timeout, AuthData authInfo = null)
{
AddZookeeper(builder, connectionString, rootPath, timeout, new List<AuthData>() { authInfo });
return AddZookeeper(builder, connectionString, rootPath, timeout, new List<AuthData>() { authInfo });
}

/// <summary>
Expand All @@ -31,7 +31,7 @@ public static void AddZookeeper(this IConfigurationBuilder builder,
/// <param name="rootPath">the zookeeper node path which you want to read it's sub node as key-value</param>
/// <param name="timeout">zookeeper session timeout in millsecond</param>
/// <param name="authInfo">authentication information to access keys on ZK</param>
public static void AddZookeeper(this IConfigurationBuilder builder,
public static IConfigurationBuilder AddZookeeper(this IConfigurationBuilder builder,
string connectionString, string rootPath, int timeout, List<AuthData> authInfo = null)
{
if (builder == null)
Expand All @@ -54,14 +54,16 @@ public static void AddZookeeper(this IConfigurationBuilder builder,
option.SessionTimeout = timeout;
option.AuthInfo = authInfo;
});

return builder;
}

/// <summary>
/// Adds a zookeeper configuration source.
/// </summary>
/// <param name="builder">The <see cref="IConfigurationBuilder"/> to add to.</param>
/// <param name="config">configures the zookeeper optoin</param>
public static void AddZookeeper(this IConfigurationBuilder builder, Action<ZookeeperOption> config)
public static IConfigurationBuilder AddZookeeper(this IConfigurationBuilder builder, Action<ZookeeperOption> config)
{
if (builder == null)
{
Expand All @@ -73,6 +75,8 @@ public static void AddZookeeper(this IConfigurationBuilder builder, Action<Zooke

var source = new ZookeeperConfigurationSource() { Option = option };
builder.Add(source);

return builder;
}
}
}