Skip to content

Cross compiling via CMake & multichannel detection#19

Closed
himwho wants to merge 50 commits intoffAudio:masterfrom
Mach1Studios:master
Closed

Cross compiling via CMake & multichannel detection#19
himwho wants to merge 50 commits intoffAudio:masterfrom
Mach1Studios:master

Conversation

@himwho
Copy link
Copy Markdown

@himwho himwho commented Oct 26, 2023

This rather large PR combines a few things:

  • cross compiling via Cmake with proper ffmpeg dep handling tested on macos and windows (linux tbd)
  • syntax fixes for windows
  • multichannel audio detection on input files
  • better module linking for ffmpeg
  • more readme for compiling

I can imagine this would bring up some questions with compiling via non-cmake and happy to adjust as needed

ffAudio and others added 30 commits March 12, 2021 13:59
* Added more granular information of the original video file

Co-authored-by: Sound Development <info@sounddevelopment.nl>
…d paths via gitkeep but ignore all other contents
himwho and others added 20 commits July 11, 2022 16:42
* mach1/develop:
  pathing error
  small improvements to script for safer usage
  Added getNumChannels method
  remove explicit error handling
  updated macos ffmpeg setup script to use homebrew entirely on stable ffmpeg version
  removed some unused libs
  removed unnecessary ffmpeg libs for windows
  fixed linking for ffmpeg libs to expected juce library paths, included paths via gitkeep but ignore all other contents
  added relative ffmpeg header path
  fixed another gl namespace
  fixed gl namespace for last JUCE
  removed avresample
  fixied audio stream init
@ffAudio
Copy link
Copy Markdown
Owner

ffAudio commented Oct 26, 2023

Wow, thank you so much for all the work. Unfortunately there seems something gone amiss with merging and rebasing.
Could you please try to rebase your work on top of master so we don't get all those merge commits?

And another thing, a week ago I started refactoring the module layout in this branch:
https://github.com/ffAudio/foleys_video_engine/tree/file-layout

The reasoning was also adding cmake, building on the CI and having the examples built, so we have some kind of testing.

I also added some code snippets that hopefully lead to a version that can use the OS media frameworks like AVFoundation and alike.

Would it be possible to work on that one instead? I cannot promise though, when I can merge the file-format branch into master. I would like to have it compile first, but maybe that is somehting that's getting easier with your work?

Thanks again and keep up the good work!

@himwho
Copy link
Copy Markdown
Author

himwho commented Oct 30, 2023

I will try to break it up into little 2 or 3 PRs instead

As for the cmake stuff, it works on macos, windows (tested) but to do so it has to pull pre-built bins for ffmpeg from 2 different sources; however its pretty streamlined in the cmakelist so ill make that the last PR in case you decide you want to do it differently

@himwho
Copy link
Copy Markdown
Author

himwho commented Nov 8, 2023

@ffAudio ok i split off the multichannel and syntax stuff to this PR: #20

i will evaluate the new cmake structure you have and see if my contribution is still warranted or otherwise switch to what you merged in!

thanks!

@himwho himwho closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants