Conversation
src/foam2dolfinx/open_foam_reader.py
Outdated
Comment on lines
134
to
158
| if self.cell_type == 12: | ||
| shape = "hexahedron" | ||
| args_conn = np.tile( | ||
| np.array([0, 1, 3, 2, 4, 5, 7, 6]), (len(self.OF_cells[subdomain]), 1) | ||
| ) | ||
|
|
||
| elif self.cell_type == 10: | ||
| shape = "tetrahedron" | ||
| args_conn = np.argsort( | ||
| self.OF_cells[subdomain], axis=1 | ||
| ) # Sort the cell connectivity | ||
|
|
||
| else: | ||
| raise ValueError( | ||
| f"Cell type: {self.cell_type}, not supported, please use" | ||
| " either 12 (hexahedron) or 10 (tetrahedron) cells in OF mesh" | ||
| ) | ||
|
|
||
| # create the connectivity between the OpenFOAM and dolfinx meshes | ||
| args_conn = np.argsort(self.OF_cells, axis=1) # Sort the cell connectivity | ||
| rows = np.arange(self.OF_cells.shape[0])[:, None] # Create row indices | ||
| self.connectivity = self.OF_cells[rows, args_conn] # Reorder connectivity | ||
| rows = np.arange(self.OF_cells[subdomain].shape[0])[ | ||
| :, None | ||
| ] # Create row indices | ||
| self.connectivity = self.OF_cells[subdomain][ | ||
| rows, args_conn | ||
| ] # Reorder connectivity |
Contributor
There was a problem hiding this comment.
Right this freaks me out and I have a hard time trusting it:
- does this work on the previous meshes still?
- why is it that @Steriva 's connectivity from pyvista doesn't work?
- how is it possible that pyvista detects several unique connectivity args and yet we force them all to be the same?
- what is
np.tile? do I sense some ChatGPT? 😄
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 97.72% 97.19% -0.54%
==========================================
Files 2 2
Lines 88 107 +19
==========================================
+ Hits 86 104 +18
- Misses 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
With this change we can now support cases with multiple subdomains
Types of changes
What types of changes does your code introduce to foam2dolfinx?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...