Implementation of the 10^23 fluence experiment for the Ogorodnikova TDS case#50
Open
rekomodo wants to merge 6 commits intofestim-dev:mainfrom
Open
Implementation of the 10^23 fluence experiment for the Ogorodnikova TDS case#50rekomodo wants to merge 6 commits intofestim-dev:mainfrom
rekomodo wants to merge 6 commits intofestim-dev:mainfrom
Conversation
Contributor
|
Can't inspect this as the docs don't compile |
rekomodo
force-pushed
the
ogorodnikova_big
branch
from
69ff3d1 to
9043be1
Compare
Contributor
|
We need to get others input on this since in theory you wouldn't have two completely different models for this. The architecture of this complete validation case should be: def run_festim_model(fluence):
...
for fluence in [1e22. 1e23]:
result = run_festim_model(fluence)
plot_tds(result, label=fluence) |
Collaborator
Author
|
Completely agree, I'll try something out later but I'll have this as low priority until they respond. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
referenced this implementation
solves #21 .
Oddly enough, this implementation appears to have half the fluence present in the original paper. Please have a look.