Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #1078 +/- ##
===========================================
- Coverage 94.77% 94.74% -0.03%
===========================================
Files 44 44
Lines 3175 3179 +4
===========================================
+ Hits 3009 3012 +3
- Misses 166 167 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Thank you so much for this @jorgensd
I see now that we might have been a bit careless here. How would you do the checkpointing differently to avoid this interpolation?
Maybe we should read the mesh of the simulation from the checkpoint file too
| # obtain mesh normal from integration domain | ||
| mesh = ds.ufl_domain() |
You can either use read/write on input mesh as described in https://scientificcomputing.github.io/io4dolfinx/docs/original_checkpoint.html (io4dolfinx/adios4dolfinx has same syntax there). I would recommend switching to io4dolfinx soon. one could also read in the mesh and function from the checkpoint for the new simulation. the possibilities/combinations are endless, but I think since most simulations use P1 elements, you could use vtkhdf backend of io4dolfinx to read/write point data, and everything should become a bit more clear (ie read in mesh, read in point data) |
Read data on grid from checkpoint, then interpolate to mesh used in simulation.
Could be modified if we change how the checkpointing is done.
Fix surfaceflux post-processing, it uses the wrong grid compared to the integration measure.
Add importorskip for ipyparallel if not installed