chore: relax a bunch of Sync requirements where unnecessary#33
Merged
ferristseng merged 2 commits intoferristseng:mainfrom Dec 5, 2024
Merged
chore: relax a bunch of Sync requirements where unnecessary#33ferristseng merged 2 commits intoferristseng:mainfrom
Sync requirements where unnecessary#33ferristseng merged 2 commits intoferristseng:mainfrom
Conversation
Owner
|
Thanks! This looks great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked: ferristseng/rust-ipfs-api#140
I noticed a weird trait restriction in https://github.com/ferristseng/rust-ipfs-api that made it so only streams implementing
Syncare permitted to the upload API. Even though the download API doesn't abide by those same rules.Effectively makes it so you can't pipe the output of, say..
catintoadd. Becauseaddexpects more thancatcan offer.And this will be the case most of the time. I looked under the hood, and couldn't find any reasons why the stream itself needs to be
Sync.So this PR gets rid of all the
Syncbounds where they are present.I've also tested it downstream with the
ipfs-apirepo and in my own project as well, and it all checks out.