Skip to content

chore(python): add apt-get cleanup and best practices in python/sdk Dockerfile#13878

Merged
fern-support merged 1 commit intomainfrom
devin/1774120498-python-sdk-apt-cleanup
Mar 21, 2026
Merged

chore(python): add apt-get cleanup and best practices in python/sdk Dockerfile#13878
fern-support merged 1 commit intomainfrom
devin/1774120498-python-sdk-apt-cleanup

Conversation

@Swimburger
Copy link
Member

@Swimburger Swimburger commented Mar 21, 2026

Description

Applies standard Dockerfile best practices to the apt invocation in the Python v1 SDK generator image.

Changes Made

  • aptapt-get (avoid the unstable CLI warning in non-interactive contexts)
  • Added --no-install-recommends to skip unnecessary suggested packages
  • Added rm -rf /var/lib/apt/lists/* to clean up the apt cache and reduce final image size

Testing

  • Visual inspection only — standard Dockerfile hygiene, no functional change

Human Review Checklist

  • Confirm --no-install-recommends doesn't drop anything curl or git need at runtime in this image (it shouldn't, but worth a sanity check if builds break)

Link to Devin session: https://app.devin.ai/sessions/371cc6bdbad447bb9161b29b0ab8ec28
Requested by: @Swimburger


Open with Devin

…ockerfile

Co-Authored-By: Niels Swimberghe <3382717+Swimburger@users.noreply.github.com>
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@fern-support fern-support merged commit 07909fd into main Mar 21, 2026
103 of 104 checks passed
@fern-support fern-support deleted the devin/1774120498-python-sdk-apt-cleanup branch March 21, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants