Update lightcurve.py #587
Open
Update lightcurve.py #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue regarding lightcurve.py crashing when a time bin has NaN values.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 49.29% 49.21% -0.08%
==========================================
Files 143 143
Lines 26962 27005 +43
==========================================
+ Hits 13290 13291 +1
- Misses 13672 13714 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
omodei
requested changes
May 17, 2024
Member
omodei
left a comment
omodei
left a comment
There was a problem hiding this comment.
Is it possible to isolate the problem a bit more, instead of incorporating so many lines of code in the trt/except block? Also, I would suggest to except with catching the exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue regarding lightcurve.py crashing when a time bin has NaN values. Generally speaking all the code does is add an extra try/except block to handle the RuntimeError thrown out by gtanalysis.py when it encounters NaN values.