Skip to content

vp migrate beta test#10

Draft
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#10
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 25, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project to use specific pre-release builds of vite-plus and @voidzero-dev/vite-plus-core via pkg.pr.new URLs. It adds documentation for Vite+ in AGENTS.md, updates .vscode/settings.json and tsconfig.json configurations, and refactors vite.config.ts to load plugins lazily using lazyPlugins. Feedback on the changes suggests using the 'catalog:' protocol for the vite-plus override in pnpm-workspace.yaml to maintain consistency and keep the configuration DRY.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
overrides:
vite: 'catalog:'
vitest: 'catalog:'
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@670c987e4097d4e5d53bb4c0521c8bf643a33cf5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since vite-plus is already defined in the catalog section, you can use the 'catalog:' protocol here in overrides to keep it DRY and consistent with how vite is configured. This ensures that any future updates to the vite-plus URL only need to be made in a single place.

  vite-plus: 'catalog:'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant