Skip to content

chore: vp migrate beta test#21

Draft
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test
Draft

chore: vp migrate beta test#21
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

No description provided.

Comment thread package.json Outdated

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's build and test configurations from standard vite and vitest to vite-plus and vite-plus/test, wrapping plugins in lazyPlugins() across various configuration files. It also updates package overrides and workspace settings to use specific preview builds of vite-plus. Feedback on these changes highlights a syntax error in examples/fumadocs-docs-template/vite.config.ts where a double comma creates an empty slot in the plugins array, and a TypeScript anti-pattern in examples/app-router-playground/tsconfig.json involving a catch-all wildcard mapping "*" in the paths configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +24 to +28
plugins: lazyPlugins(() => [
tailwindcss(),
mdx(MdxConfig),,
vinext(),
],
]),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a double comma after mdx(MdxConfig) which creates an empty/undefined slot in the plugins array. This can lead to unexpected behavior or errors during Vite's plugin resolution. Let's clean it up by removing the extra comma.

Suggested change
plugins: lazyPlugins(() => [
tailwindcss(),
mdx(MdxConfig),,
vinext(),
],
]),
plugins: lazyPlugins(() => [
tailwindcss(),
mdx(MdxConfig),
vinext(),
]),

Comment thread examples/app-router-playground/tsconfig.json
Comment thread examples/app-router-playground/tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant