chore: vp migrate beta test#21
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project's build and test configurations from standard vite and vitest to vite-plus and vite-plus/test, wrapping plugins in lazyPlugins() across various configuration files. It also updates package overrides and workspace settings to use specific preview builds of vite-plus. Feedback on these changes highlights a syntax error in examples/fumadocs-docs-template/vite.config.ts where a double comma creates an empty slot in the plugins array, and a TypeScript anti-pattern in examples/app-router-playground/tsconfig.json involving a catch-all wildcard mapping "*" in the paths configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| plugins: lazyPlugins(() => [ | ||
| tailwindcss(), | ||
| mdx(MdxConfig),, | ||
| vinext(), | ||
| ], | ||
| ]), |
There was a problem hiding this comment.
There is a double comma after mdx(MdxConfig) which creates an empty/undefined slot in the plugins array. This can lead to unexpected behavior or errors during Vite's plugin resolution. Let's clean it up by removing the extra comma.
| plugins: lazyPlugins(() => [ | |
| tailwindcss(), | |
| mdx(MdxConfig),, | |
| vinext(), | |
| ], | |
| ]), | |
| plugins: lazyPlugins(() => [ | |
| tailwindcss(), | |
| mdx(MdxConfig), | |
| vinext(), | |
| ]), |
No description provided.