Skip to content

chore: vp migrate beta test#10

Draft
fengmk2 wants to merge 1 commit into
devfrom
vp-migrate-test
Draft

chore: vp migrate beta test#10
fengmk2 wants to merge 1 commit into
devfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures the project to use the Vite+ unified toolchain, updating VS Code settings, adding documentation, and modifying dependency configurations across the monorepo packages. Feedback on the changes suggests removing a redundant vite-plus declaration in packages/varlet-cli/package.json and maintaining monorepo consistency by using the catalog: protocol for @vitest/coverage-istanbul in packages/varlet-ui/package.json while updating its version in pnpm-workspace.yaml.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +78 to +79
"rimraf": "catalog:",
"vite-plus": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The vite-plus dependency is already declared in dependencies on line 63. Declaring it again in devDependencies is redundant and should be removed.

    "rimraf": "catalog:"

Comment thread packages/varlet-ui/package.json Outdated
"devDependencies": {
"@types/node": "catalog:",
"@vitest/coverage-istanbul": "catalog:",
"@vitest/coverage-istanbul": "4.1.9",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistent dependency management across the monorepo, @vitest/coverage-istanbul should be defined as "catalog:" here, and its version should be updated to 4.1.9 in pnpm-workspace.yaml.

Suggested change
"@vitest/coverage-istanbul": "4.1.9",
"@vitest/coverage-istanbul": "catalog:",

Comment thread pnpm-workspace.yaml Outdated
vite-plus: 0.1.18
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1891
'@types/node': ^20.19.0
'@vitest/coverage-istanbul': 4.1.4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the catalog version of @vitest/coverage-istanbul to 4.1.9 to match the version used in packages/varlet-ui/package.json.

  '@vitest/coverage-istanbul': 4.1.9

@pkg-pr-new

pkg-pr-new Bot commented Jun 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@varlet/cli

npm i https://pkg.pr.new/@varlet/cli@10

@varlet/icons

npm i https://pkg.pr.new/@varlet/icons@10

@varlet/import-resolver

npm i https://pkg.pr.new/@varlet/import-resolver@10

@varlet/preset-tailwindcss

npm i https://pkg.pr.new/@varlet/preset-tailwindcss@10

@varlet/preset-unocss

npm i https://pkg.pr.new/@varlet/preset-unocss@10

@varlet/shared

npm i https://pkg.pr.new/@varlet/shared@10

@varlet/touch-emulator

npm i https://pkg.pr.new/@varlet/touch-emulator@10

@varlet/ui

npm i https://pkg.pr.new/@varlet/ui@10

@varlet/use

npm i https://pkg.pr.new/@varlet/use@10

@varlet/vite-plugins

npm i https://pkg.pr.new/@varlet/vite-plugins@10

commit: 2b67963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant