Skip to content

chore(deps): bump vite-plus to pkg-pr-new PR #1703#1

Draft
fengmk2 wants to merge 4 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703
Draft

chore(deps): bump vite-plus to pkg-pr-new PR #1703#1
fengmk2 wants to merge 4 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-workspace.yaml file to use pkg.pr.new URLs for vite, vite-plus, and vitest dependencies, and adds corresponding overrides. It also configures blockExoticSubdeps and minimumReleaseAge settings. The reviewer pointed out an inconsistency where the catalog definitions use a PR number while the overrides use a specific commit hash, which could lead to version conflicts if the upstream PR is updated. It is recommended to pin both to the same commit hash.

Comment thread pnpm-workspace.yaml
Comment on lines +55 to +59
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703
vite-plugin-externals: ^0.6.2
vite-plugin-monkey: ^8.0.5
vite-plus: ^0.1.22
vitest: npm:@voidzero-dev/vite-plus-test@^0.1.22
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1703
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is an inconsistency between the catalog definitions (which use the PR number @1703) and the overrides definitions (which use the specific commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8).

If the upstream PR is updated with new commits, the catalog dependencies will resolve to the latest commit of the PR, while the overrides will remain pinned to the older commit. This mismatch can lead to duplicate packages or version conflicts in the lockfile.

To ensure deterministic builds and consistency, please pin the catalog dependencies to the same commit hash.

  vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vite-plugin-externals: ^0.6.2
  vite-plugin-monkey: ^8.0.5
  vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8

@fengmk2 fengmk2 changed the title chore(deps): bump vite-plus to pkg-pr-new PR #1703 (d0b407c) chore(deps): bump vite-plus to pkg-pr-new PR #1703 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant