Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588#5

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1588
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588#5
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1588

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a bunfig.toml configuration to exclude specific packages from the minimum release age requirement and updates dependencies in package.json to use PR-specific builds of vite-plus packages. The reviewer recommended pointing the vite override directly to the PR build URL instead of @latest to ensure consistency, and suggested removing the unused @voidzero-dev/vite-plus-test package from the minimumReleaseAgeExcludes list in bunfig.toml since it was removed from package.json.

Comment thread package.json
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20"
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e",
"vite": "npm:@voidzero-dev/vite-plus-core@latest"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Overriding vite to npm:@voidzero-dev/vite-plus-core@latest can cause the package manager to fetch the latest published version of @voidzero-dev/vite-plus-core from the npm registry instead of using the PR build URL specified in the overrides. To ensure the PR build is consistently used, override vite directly to the pkg.pr.new URL.

Suggested change
"vite": "npm:@voidzero-dev/vite-plus-core@latest"
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e"

Comment thread bunfig.toml
Comment on lines +5 to +7
"@voidzero-dev/vite-plus-core",
"@voidzero-dev/vite-plus-test",
"@voidzero-dev/vite-plus-prompts",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since @voidzero-dev/vite-plus-test has been replaced by upstream vitest and removed from package.json, it is no longer needed in the minimumReleaseAgeExcludes list.

Suggested change
"@voidzero-dev/vite-plus-core",
"@voidzero-dev/vite-plus-test",
"@voidzero-dev/vite-plus-prompts",
"@voidzero-dev/vite-plus-core",
"@voidzero-dev/vite-plus-prompts",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant